RFR: 8289607: Change hotspot/jtreg tests to not use Thread.suspend/resume [v4]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Sep 23 09:13:15 UTC 2022


On Thu, 22 Sep 2022 15:05:37 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The Thread.suspend/resume is replaced by JVM TI  SuspendThread/ResumeThread whether it is possible. 
>> Testcase from test  test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java was removed because only one environment can suspend threads so debugger is not compatible with JVM TI agent suspending test.
>> 
>> Test test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java starts failing because it got JVMTI_ERROR_INTERNAL. The problem is that JvmtiSuspendControl::resume() returned false. However, it might happen only if the thread is not suspended, which means that it should be JVMTI_ERROR_THREAD_NOT_SUSPENDED.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix

Looks good.
Thank you for the update.
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10351


More information about the hotspot-dev mailing list