RFR: JDK-8293711: Factor out size parsing functions from arguments.cpp [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri Sep 23 14:08:25 UTC 2022
On Fri, 23 Sep 2022 07:34:09 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> > is the new version acceptable?
>
> I would have preferred if the parsing code were not placed in a .hpp file, and would have placed it in a .inline.hpp file, to comply with our guidelines. Other than that, I'm OK with this patch.
Almost missed your comment :-)
I'll split it up as you suggested, then push.
-------------
PR: https://git.openjdk.org/jdk/pull/10252
More information about the hotspot-dev
mailing list