RFR: 8137022: Concurrent refinement thread adjustment and (de-)activation suboptimal [v3]

[Kim Barrett]

On Sat, 24 Sep 2022 14:44:29 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - wanted vs needed nomenclature
>>  - remove several spurious "scan"
>>  - delay => wait_time_ms
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 203:
> 
>> 201: }
>> 202: 
>> 203: void G1ConcurrentRefine::update_pending_cards_target(double logged_cards_time_ms,
> 
> Since this method doesn't always do the update, maybe prefix the name with `try_`.

That it might leave the value unchanged when the data isn't good is an
implementation detail, not part of the API. A common case where this arises is
during application startup, when there might not be much or any GC refinement
to do (little or no oldgen).  The caller should just always treat it as doing
an update, and not do something different depending on a try_ result.

-------------

PR: https://git.openjdk.org/jdk/pull/10256