RFR: 8294293: Remove unused _width and _newlines field in outputStream [v2]

[David Holmes]

On Mon, 26 Sep 2022 08:38:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/hotspot/share/utilities/ostream.cpp line 904:
>> 
>>> 902:   if (has_log_file()) {
>>> 903:     int nl0 = _newlines;
>>> 904:     xmlTextStream::write(s, len);
>> 
>> xmlTextStream::write seems to be unused after this change.
>
> It does seem that way. The `outputStream::write` method is the function which all subclasses of `outputStream` implements, so we shouldn't remove this function without removing `xmlTextStream`. That's probably a separate RFE, and perhaps not desirable as it'd require merging the class into  `defaultStream`.

I'm confused by this part of the change. How can the original code call `xmlTextStream::write` without an instance of `xmlTextStream` to apply it to???

-------------

PR: https://git.openjdk.org/jdk/pull/10411