RFR: 8293691: converting a defined BasicType value to a string should not crash the VM

Aleksey Shipilev shade at openjdk.org
Tue Sep 27 12:18:32 UTC 2022


On Tue, 27 Sep 2022 11:21:40 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> This implements Kim's suggested fix for this ticket.

Looks okay to me, with a nit.

src/hotspot/share/utilities/globalDefinitions.cpp line 240:

> 238: };
> 239: const char* type2name(BasicType t) {
> 240:   if (t < (T_CONFLICT + 1)) {

Looks cleaner to do `if (t <= T_CONFLICT)`, maybe?

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10447


More information about the hotspot-dev mailing list