RFR: 8293691: converting a defined BasicType value to a string should not crash the VM

Johan Sjölen jsjolen at openjdk.org
Tue Sep 27 13:15:30 UTC 2022


On Tue, 27 Sep 2022 13:12:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Hm, yeah. This looks like this to create symmetry with the declaration of `type2name_tab`:
>> 
>> 
>> extern const char* type2name_tab[T_CONFLICT+1];     // Map a BasicType to a char*
>> 
>> 
>> But the symmetry is lost here as they're in 2 different files now. I'd like a RFE where `type2name_tab` is no longer external which will make the symmetry apparent again. Can we ignore this nit in anticipation of that change?
>
> I honestly don't care about this nit either way :) You decide.

Alright, I'll let it be then :).

-------------

PR: https://git.openjdk.org/jdk/pull/10447


More information about the hotspot-dev mailing list