RFR: 8294314: Minimize disabled warnings in hotspot [v4]

[Magnus Ihse Bursie]

On Tue, 27 Sep 2022 15:16:44 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> You mentioned shift-negative-value earlier in this PR. I apologize I forgot about it.
>> 
>> I can't find any discussion about JDK-8211073 wrt to `-Wempty-body` (are you sure this is the correct bug ID?), but I can put that as well to the globally disabled set.
>> 
>> As for xlc, I have no access to that compiler and I have therefore not done much changes here. But I think xlc compiles with "warnings as errors" off by default so most likely the people still supporting the AIX port don't care that much about warnings.
>
> JDK-8211073 is the correct bug id. 
> 
> JDK-8211073 Remove -Wno-extra from Hotspot
> 
> There were two attempts at addressing this, about a year apart.
> The first one can be found here:
> https://mail.openjdk.org/pipermail/hotspot-dev/2018-September/034314.html
> and continuing here:
> https://mail.openjdk.org/pipermail/hotspot-dev/2018-October/034496.html
> with the explanation for disabling `-Wempty-body` here:
> https://mail.openjdk.org/pipermail/hotspot-dev/2018-October/034526.html
> 
> The second, successful, attempt at it is here:
> https://mail.openjdk.org/pipermail/hotspot-dev/2019-October/039808.html
> 
> Leaving xlc to the relevant port maintainers seems like a wise choice.

Thanks. I tried searching but my mail archives did not include all of that discussion.

I have now globally disabled empty-body and shift-negative-value for all of hotspot.

-------------

PR: https://git.openjdk.org/jdk/pull/10414