RFR: 8294160: misc crash dump improvements [v2]

[Dean Long]

On Tue, 27 Sep 2022 06:19:51 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert unneeded changes
>
> src/hotspot/share/utilities/vmError.cpp line 353:
> 
>> 351: 
>> 352:   // see if it's a valid frame
>> 353:   if (fr.sp() != nullptr && os::is_readable_pointer(fr.sp())) {
> 
> Why did you completely change the notion of "valid frame" here?

I needed for an early version of the patch, but I can remove it now.  Using sp() instead of pc() could possibly give more progress on weird native frames, and is_readable_pointer() prevents some crashes during stack walking.

-------------

PR: https://git.openjdk.org/jdk/pull/10387