RFR: 8294293: Remove unused _width and _newlines field in outputStream [v2]

[David Holmes]

On Tue, 27 Sep 2022 07:23:18 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> I'm confused by this part of the change. How can the original code call `xmlTextStream::write` without an instance of `xmlTextStream` to apply it to???
>
> `defaultStream` inherits from `xmlTextStream` and `defaultStream::write` exists, so this specifies to call the superclass method, and not its own method. In long form: `this->xmlTextStream::write` (haven't attempted to compile)

Ah! Thanks - I had missed this code was in `defaultStream`. It seems a bit klunky to break encapsulation and effectively inline the super write() call so that we can get access to whether a newline was seen - but monitoring `_newlines` across the write call is at least as bad. I guess this is the problem of trying to have a flushable stream extend a non-flushable superclass - you somehow need to see inside the write to know if there were newlines. The new code at least saves the need for the field.

-------------

PR: https://git.openjdk.org/jdk/pull/10411