RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]

Johan Sjölen jsjolen at openjdk.org
Thu Sep 29 08:52:16 UTC 2022


On Wed, 28 Sep 2022 18:21:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Introduce new, invalid, memory flag
>>  - delete _print_inlining_stream
>>  - Merge remote-tracking branch 'origin/master' into dyn-cheapobj
>>  - Avoid leaking predString
>>  - Try out Coleen's suggestion
>>  - DynCHeapObj
>
> src/hotspot/share/opto/compile.hpp line 1064:
> 
>> 1062:     delete _print_inlining_stream;
>> 1063:   };
>> 1064: 
> 
> compile.cpp has print_inlining_stream_free() calls which will leak the stringStream now if called.  I think this function needs to be removed and it should call the reset function to reinitialize the stream.
> There should be compiler tests that will fail if print_inlining_stream_free() is called with a null _print_inlining_stream pointer (I think the delete should fail (?) with null)

This is removed as part of https://github.com/openjdk/jdk/pull/10396 . The function used to be here but I merged with upstream when that went in. delete on null is OK, just like with free.

-------------

PR: https://git.openjdk.org/jdk/pull/10412


More information about the hotspot-dev mailing list