RFR: 8304743: Compile_lock and SystemDictionary updates

Coleen Phillimore coleenp at openjdk.org
Sat Apr 1 00:09:25 UTC 2023


On Fri, 31 Mar 2023 21:24:27 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> The SystemDictionary is updated and read under the Compile_lock but this is unnecessary because the table is a concurrent hashtable, and the lock doesn't really synchronize any other compilation state.  The lock may have protected other state that Dependencies used in the past but has been removed.   See discussion in CR for more information.
>> Tested with tier1-8.
>
> src/hotspot/share/ci/ciEnv.cpp line 519:
> 
>> 517: 
>> 518:   Klass* found_klass;
>> 519:   if (!require_local) {
> 
> Since JVMCI needs the very same code, does it make sense to put it into a wrapper method?

This is a good idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13270#discussion_r1155015640


More information about the hotspot-dev mailing list