RFR: 8304743: Compile_lock and SystemDictionary updates [v3]

[David Holmes]

On Sat, 1 Apr 2023 13:27:17 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The SystemDictionary is updated and read under the Compile_lock but this is unnecessary because the table is a concurrent hashtable, and the lock doesn't really synchronize any other compilation state.  The lock may have protected other state that Dependencies used in the past but has been removed.   See discussion in CR for more information.
>> Tested with tier1-8.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Missing null check

Seems fine based on the analysis that has been done. Hope no one tries to backport this without also doing thorough analysis!

Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13270#pullrequestreview-1368156833