RFR: 8305509: C1 fails "assert(k != nullptr) failed: illegal use of unloaded klass"

[David Holmes]

On Tue, 4 Apr 2023 14:32:42 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> I tested the fix for JDK-8304743 on tier1-8, then did this refactoring which required a ciKlass::get_Klass() call that failed.  This fix reverts the refactoring.
> 
> Here was the commit for JDK-8304743: https://github.com/openjdk/jdk/commit/b062b1bd8126610d9288dc179d69e54a40b81015
> 
> I added the HandleMark to the utility function.  It wasn't there in the original code.
> 
> Tested with tier4.

I'll add an after-the-fact review.

I needed to understand where the code review had failed and see now how the original code uses a `ciKlass` not a `klass`.

Backout looks good. Thanks.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13327#pullrequestreview-1372050576