RFR: 8287325: AArch64: fix virtual threads with -XX:UseBranchProtection=pac-ret [v2]

Hao Sun haosun at openjdk.org
Fri Apr 7 03:25:48 UTC 2023


On Thu, 6 Apr 2023 02:48:03 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/continuationHelper_aarch64.inline.hpp line 72:
>> 
>>> 70: 
>>> 71: inline address ContinuationHelper::return_pc_at(intptr_t* sp) {
>>> 72:   return pauth_strip_pointer(*(address*)sp);
>> 
>> This is the return address. it's called `return_address` elsewhere.
>
> I used `return_pc_at()` following the usage of `ContinuationHelper::Frame::return_pc()` and `ContinuationHelper::InterpretedFrame::return_pc()`.
> 
> How about `get_pc_at()` or `return_address_at()`? 
> Thanks.

Rename to `return_address_at()` in the latest revision. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13322#discussion_r1160407248


More information about the hotspot-dev mailing list