RFR: JDK-8301497: Replace NULL with nullptr in cpu/s390

[Lutz Schmidt]

On Mon, 13 Feb 2023 10:16:01 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory cpu/s390. Unfortunately the script that does the change isn't perfect, and so we
>> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>> 
>> Here are some typical things to look out for:
>> 
>> 1. No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
>> 2. Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
>> 3. nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>> 
>> An example of this:
>> 
>> ```c++
>> // This function returns null
>> void* ret_null();
>> // This function returns true if *x == nullptr
>> bool is_nullptr(void** x);
>> 
>> 
>> Note how `nullptr` participates in a code expression here, we really are talking about the specific value `nullptr`.
>> 
>> Thanks!
>
> src/hotspot/cpu/s390/vtableStubs_s390.cpp line 85:
> 
>> 83: 
>> 84:   const Register rcvr_klass   = Z_R1_scratch;
>> 85:   address        npe_addr     = __ pc(); // npe == null ptr exception
> 
> This reads a bit strange.

Read this as "npe means null pointer exception" or however you would like to spell it.

> src/hotspot/cpu/s390/vtableStubs_s390.cpp line 198:
> 
>> 196:   // Get receiver klass.
>> 197:   // Must do an explicit check if offset too large or implicit checks are disabled.
>> 198:   address npe_addr = __ pc(); // npe == null ptr exception
> 
> This also reads a bit strange

Read this as "npe means null pointer exception" or however you would like to spell it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12325#discussion_r1105994804
PR Review Comment: https://git.openjdk.org/jdk/pull/12325#discussion_r1105995129