RFR: 8302328: [s390x] Simplify asm_assert definition [v2]

Martin Doerr mdoerr at openjdk.org
Thu Apr 13 14:24:39 UTC 2023


On Thu, 13 Apr 2023 13:47:09 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> `z_bre` + `asm_assert(Assembler::bcondEqual, ...` still doesn't make sense to me.
>
> z_bre is a "branch if equal". Everything is fine if both registers contain the same value. Otherwise, there is something wrong.

Seems like you didn't get my point. The `z_bre` is fine, but the assert condition "bcondEqual" can't be true after that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1165604157


More information about the hotspot-dev mailing list