RFR: JDK-8302989: Add missing INCLUDE_CDS checks [v4]

[David Holmes]

On Fri, 3 Mar 2023 08:55:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> The cds only coding in hotspot is usually guarded with the INCLUDE_CDS macro so that it can be removed at compile time in case the correct configure flags are set.
>> However at some places INCLUDE_CDS is missing and should be added.
>> 
>> One question - should (additionally to the UseSharedSpaces code section)  the DumpSharedSpaces code sections be guarded as well with INCLUDE_CDS macros ?
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adjust arguments handling

I'm a bit confused about the testing situation as you indicated `-Xshare:off` causes an error on AIX without CDS, yet Ioi showed it doesn't cause an error when used with the MinimalVM which also doesn't have CDS. I think Ioi's earlier suggestion regarding handling of the different `-Xshare:` flags is worth looking at from the testing perspective (only `on` should cause an error on systems without CDS). But that would be a separate issue. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12691#issuecomment-1510688864