RFR: JDK-8301223: Replace NULL with nullptr in share/gc/g1/ [v2]

Kim Barrett kbarrett at openjdk.org
Tue Apr 18 19:34:44 UTC 2023


On Tue, 18 Apr 2023 14:49:17 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hm, got some funny errors:
> 
> ```
> 
> === Output from failing command(s) repeated here ===
> * For target hotspot_variant-server_libjvm_objs_filemap.o:
> /home/runner/work/jdk/jdk/src/hotspot/share/cds/filemap.cpp: In member function 'void FileMapInfo::seek_to_position(size_t)':
> /home/runner/work/jdk/jdk/src/hotspot/share/cds/filemap.cpp:1429:50: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t' {aka 'unsigned int'} [-Werror=format=]
>  1429 |     log_error(cds)("Unable to seek to position %ld", pos);
>       |                                                ~~^   ~~~
>       |                                                  |   |
>       |                                                  |   size_t {aka unsigned int}
>       |                                                  long int
>       |                                                %d
> cc1plus: all warnings being treated as errors
> ```
> 
> I'll have to look into the merge and see if I messed that up. Worst case, I'll re-apply the nullptr conversion to origin/master.

That seems to be  https://bugs.openjdk.org/browse/JDK-8306289, which has been fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/12248#issuecomment-1513691025


More information about the hotspot-dev mailing list