RFR: 8305252: make_method_handle_intrinsic may call java code under a lock [v2]

[Coleen Phillimore]

On Wed, 19 Apr 2023 06:34:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update method deallocate_contents comments.
>
> src/hotspot/share/oops/method.cpp line 141:
> 
>> 139:   // for method handle intrinsics.
>> 140:   if (code() != nullptr) {
>> 141:     ((nmethod*)_code)->flush();
> 
> `flush` acquires the CodeCache_lock - could that be an issue in this call path?

The call path to this is during a safepoint for cleaning up the deallocate lists, and the CodeCache_lock is a pretty low level no-safepoint lock, so the lock is fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13308#discussion_r1171542403