RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]
Fredrik Bredberg
duke at openjdk.org
Fri Apr 21 13:29:52 UTC 2023
On Tue, 18 Apr 2023 12:01:05 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated after review
>
> src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp line 149:
>
>> 147: // on AARCH64, we may insert padding between the locals and the rest of the frame
>> 148: // (see TemplateInterpreterGenerator::generate_normal_entry, and AbstractInterpreter::layout_activation)
>> 149: // since we freeze the padding word (see recurse_freeze_interpreted_frame) in order to keep the same relativized
>
> Suggestion:
>
> // because we freeze the padding word (see recurse_freeze_interpreted_frame) in order to keep the same relativized
>
> ... for clarity.
Fixed (in all platforms).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173763746
More information about the hotspot-dev
mailing list