RFR: 8300197: Freeze/thaw an interpreter frame using a single copy_to_chunk() call [v2]
Fredrik Bredberg
duke at openjdk.org
Fri Apr 21 13:29:55 UTC 2023
On Tue, 18 Apr 2023 12:48:45 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> src/hotspot/share/runtime/continuationFreezeThaw.cpp line 2157:
>>
>>> 2155:
>>> 2156: // Some architectures (like AArch64/PPC64/RISC-V) adds padding between the locals and the fixed_frame to keep the fp 16-byte-aligned.
>>> 2157: // On those architectures we thaw the padding in order to keep the same localized pointer values.
>>
>> Somehow this suggestion was not delivered...
>> Suggestion:
>>
>> // On those architectures we thaw the padding in order to keep the same relative references.
>
> This is very unclear. I think it means the same "relative pointers," otherwise known as "offsets."
Tried to clarify by changing the comment to:
`// On those architectures we freeze the padding in order to keep the same fp-relative offsets in the fixed_frame.`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13477#discussion_r1173765981
More information about the hotspot-dev
mailing list