RFR: JDK-8305506: Add support for fractional values of SafepointTimeoutDelay [v2]

Wojciech Kudla duke at openjdk.org
Mon Apr 24 08:01:44 UTC 2023


On Fri, 21 Apr 2023 10:31:30 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Changing the type of a product flag requires a CSR (https://wiki.openjdk.org/display/csr/CSR+FAQs).

This is my first of two initial contributions, I don't have Author status yet. Could you please raise CSR on my behalf?

> src/hotspot/share/runtime/safepoint.cpp line 382:
> 
>> 380:     // Set the limit time, so that it can be compared to see if this has taken
>> 381:     // too long to complete.
>> 382:     safepoint_limit_time = SafepointTracing::start_of_safepoint() + (jlong)SafepointTimeoutDelay * NANOSECS_PER_MILLISEC;
> 
> I think it should be `(SafepointTimeoutDelay * NANOSECS_PER_MILLISEC)` before converting to jlong.

Thank you @TheRealMDoerr for reviewing. I just committed a change with your suggestion.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13373#issuecomment-1519570097
PR Review Comment: https://git.openjdk.org/jdk/pull/13373#discussion_r1174916418


More information about the hotspot-dev mailing list