RFR: 8306732: TruncatedSeq::predict_next() attempts linear regression with only one data point
Kim Barrett
kbarrett at openjdk.org
Tue Apr 25 14:43:13 UTC 2023
On Mon, 24 Apr 2023 11:51:06 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
> TruncatedSeq::predict_next() attempts linear regression with only one data point, this leads to a division by zero. (There are infinit many linear functions that fit equally well for a single point).
>
> I suggest we do what we do for the zero points case, namely pick one of the linear functions.
>
> For zero points the current version picks `y = 0 + 0*x` and the suggestion is that for one point `P` the function `y = P_y + 0*x` is picked.
>
> Tested for ZGC tier1-7 on Oracle supported platforms. Only ZGC use TruncatedSeq::predict_next()
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13614#pullrequestreview-1400081485
More information about the hotspot-dev
mailing list