RFR: 8302328: [s390x] Simplify asm_assert definition [v2]

Martin Doerr mdoerr at openjdk.org
Wed Apr 26 09:50:53 UTC 2023


On Wed, 26 Apr 2023 03:20:42 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>>> What about using `stop` or anything which doesn't take a condition? That would avoid confusion.
>> 
>> That is a good idea. It's of no benefit to check for the complement of the condition above.
>
> I'll update it with `stop`.

Thanks! That's much better readable. Note that there are more places like https://github.com/openjdk/jdk/blob/5635d301d89f62874969e475b53dcbd155aa56cb/src/hotspot/cpu/s390/stubRoutines_s390.cpp#L68. In addition, you don't need the illtrap after stop any more. Would be great if you could clean it up.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12822#discussion_r1177616127


More information about the hotspot-dev mailing list