RFR: 8306460: Clear JVM_ACC_QUEUED flag on methods when dumping dynamic CDS archive
Ashutosh Mehra
duke at openjdk.org
Wed Apr 26 13:15:53 UTC 2023
On Tue, 25 Apr 2023 21:48:28 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> This patch clears the method's "queued_for_compilation" flag when dumping the method in CDS archive. Also added an assert in `Method::restore_unshareable_info()` that the method being restored should not have that flag set.
>
> There are other compiler-related flags (e.g., `JVM_ACC_NOT_C1_COMPILABLE`/`JVM_ACC_NOT_C2_COMPILABLE`/`JVM_ACC_NOT_C2_OSR_COMPILABLE` ) which should not be persisted into CDS archive.
>
> Also, I assume the following flags should be always unset in the archived version:
> `JVM_ACC_IS_PREFIXED_NATIVE`, `JVM_ACC_HAS_RESOLVED_METHOD`, `JVM_ACC_IS_OLD`, `JVM_ACC_IS_OBSOLETE`, `JVM_ACC_ON_STACK`, `JVM_ACC_IS_DELETED`, `JVM_ACC_IS_BEING_REDEFINED`.
@iwanowww I don't see `JVM_ACC_HAS_RESOLVED_METHOD` and `JVM_ACC_IS_BEING_REDEFINED` used/referred anywhere in the code base. Where do you see them?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13652#issuecomment-1523386687
More information about the hotspot-dev
mailing list