RFR: 8313322: RISC-V: implement MD5 intrinsic [v2]

[Antonios Printezis]

On Tue, 1 Aug 2023 04:52:49 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Antonios Printezis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changes based on code review feedback
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1975:
> 
>> 1973:   assert_different_registers(dst, tmp);
>> 1974:   assert_different_registers(src, tmp);
>> 1975:   assert(shift < 64, "shift amount must be < 64");
> 
> shift should probably be less than 32.

Copy pasta! Will fix.

> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 599:
> 
>> 597:     assert_cond(dest != nullptr);                                                                        \
>> 598:     int64_t offset = dest - pc();                                                                        \
>> 599:     guarantee(is_simm13(offset) && ((offset % 2) == 0),                                                  \
> 
> bool is_even(intx x) instead of mod ?

I'll change it, but note that I didn't modify the condition, just the error message!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15090#discussion_r1280574819
PR Review Comment: https://git.openjdk.org/jdk/pull/15090#discussion_r1280576631