RFR: 8306582: Remove MetaspaceShared::exit_after_static_dump() [v4]

[David Holmes]

On Tue, 1 Aug 2023 21:02:36 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> src/hotspot/share/oops/constantPool.cpp line 308:
>> 
>>> 306:           assert(java_lang_String::is_instance(obj), "must be");
>>> 307:           if (!ArchiveHeapWriter::is_string_too_large_to_archive(obj)) {
>>> 308:             scratch_rr->obj_at_put(i, nullptr);
>> 
>> Should the above be the following?
>> `scratch_rr->obj_at_put(i, obj);`
>
> Yes it should! Thank you for catching this.

This suggests we don't have test coverage for this case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14879#discussion_r1281362007