RFR: 8313564: Fix -Wconversion warnings in classfile code [v4]

Dean Long dlong at openjdk.org
Thu Aug 3 10:55:37 UTC 2023


On Thu, 3 Aug 2023 01:37:08 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This patch fixes various -Wconversion warnings in classfile code.  I broke the change into commits so the changes are easier to see.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix Atomic items_added code.

src/hotspot/share/classfile/symbolTable.cpp line 90:

> 88: static size_t _current_size = 0;
> 89: 
> 90: static volatile int    _items_count = 0;

Shouldn't there be a check somewhere that this value doesn't overflow?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15111#discussion_r1283026840


More information about the hotspot-dev mailing list