RFR: 8313752: InstanceKlassFlags::print_on doesn't print the flag names

Aleksey Shipilev shade at openjdk.org
Fri Aug 4 11:57:32 UTC 2023


On Fri, 4 Aug 2023 11:28:50 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> I've found that our misc flags printing is broken. This can be seen in our hs_err files:
> 
> RCX=0x00007f86bf0073c8 is a pointer to class: 
> java.lang.Class {0x00007f86bf0073c8}
>  - instance size:     22
>  - klass size:        97
>  - access:            public final synchronized 
>  - flags:              ##name  ##name  ##name  ##name  ##name  ##name 
> 
> 
> With this fix the flags are now printed as expected:
> 
> java.util.Hashtable {0x00007f5fff00e8c0}
>  - instance size:     8
>  - klass size:        123
>  - access:            public synchronized 
>  - flags:              rewritten  has_nonstatic_fields  has_nonstatic_concrete_methods  is_shared_boot_class  has_localvariable_table  has_final_method 
> 
> 
> The indentation doesn't look that great, so if you want me to change it I can do so in this patch as well.

Seems like introduced by https://github.com/openjdk/jdk/commit/316d303c1da550c9589c9be56b65650964e3886b#diff-1986c820f9f6ad5652414e734fa6d18cde5808bf943e220bcd99f8cd6e1c9eedR57

If we change the spaces, then `ConstMethodFlags::print_on` might need a change too.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15153#issuecomment-1665491284


More information about the hotspot-dev mailing list