RFR: 8312623: SA add NestHost and NestMembers attributes when dumping class

Thomas Stuefe stuefe at openjdk.org
Fri Aug 4 18:45:44 UTC 2023


On Mon, 24 Jul 2023 22:12:28 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

> This patch adds NestHost and NestMembers attributes to the class dumped by SA.
> 
> Testing: `test/hotspot/jtreg/serviceability/sa` and `test/jdk/sun/tools/jhsdb`
> Manual testing by dumping `j.l.String` and `j.l.String$CaseInsensitiveComparator` classes.
> `j.l.String` shows one entry in `NestMembers` attribute for `j.l.String$CaseInsensitiveComparator` and `j.l.String$CaseInsensitiveComparator` has `j.l.String` as its `NestHost`.

Belatedly, and unnecessary since you have two reviews, but this looks good to me too.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15005#pullrequestreview-1563382820


More information about the hotspot-dev mailing list