RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp

David Holmes dholmes at openjdk.org
Mon Aug 7 02:40:34 UTC 2023


On Sat, 5 Aug 2023 16:21:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 1590:
>> 
>>> 1588:           "switch")                                                         \
>>> 1589:                                                                             \
>>> 1590:   develop(int, StopInterpreterAt, 0,                                        \
>> 
>> Some cpu ports access this from assembly, so changing the size is gong to require cpu-specific changes.  I'd rather see this and BytecodeCounter::_counter_value both changed to uint64_t.
>
> share/interpreter/bytecodeHistogram.cpp:int   BytecodeCounter::_counter_value = 0;
> 
> Maybe this should be inx instead.

The only reason to use `intx` is if this should be 32-bit on 32-bit and 64-bit on 64-bit. I don't think that is the case here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1285312430


More information about the hotspot-dev mailing list