RFR: 8307352: AARCH64: Improve itable_stub [v2]

Boris Ulasevich bulasevich at openjdk.org
Mon Aug 7 09:10:34 UTC 2023


On Wed, 12 Jul 2023 11:46:09 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> I wonder if you can get rid of `temp_reg3` (and the `holder_offset` argument of `MacroAssembler::lookup_interface_method_stub()`) by defining `resolved_klass_reg` as `r17` in `VtableStubs::create_itable_stub()` and defining `Register holder_offset = method_result` as local variable in `MacroAssembler::lookup_interface_method_stub()` (the usages of `holder_offset` and `method_result` don't seem to overlap).

I think it does not work. Non-overlapping registers are already optimized: resolved_klass and method_result are actually reusing the same rmethod(r12) register.

> Otherwise looks good.

Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13792#issuecomment-1667479781


More information about the hotspot-dev mailing list