RFR: 8307352: AARCH64: Improve itable_stub [v5]

Boris Ulasevich bulasevich at openjdk.org
Mon Aug 7 09:10:35 UTC 2023


On Mon, 10 Jul 2023 11:33:35 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> What I am trying to say is that I have not found any benchmark or application where a performance impact of TemplateTable::invokeinterface is visible. I would be happy to rework it as well once we see a benchmark which clearly demonstrates the gain, and the gain is substantial to justify the code complexity.
>
> @bulasevich 
>> What I am trying to say is that I have not found any benchmark
> 
> IMHO you can run the benchmark mentioned in the description with `-Xint`.
> 
>> Unfortunately, the instructions in between the lookup_interface_method calls are different, making it difficult to create a common stub for them.
> 
> If it needs a lot of work, we can create a JBS issue to implement the same approach for the interpreter. When it is being implemented some common parts might be identified and refactored.

Right. I created a separate issue for this task: https://bugs.openjdk.org/browse/JDK-8313870

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13792#discussion_r1285587456


More information about the hotspot-dev mailing list