RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer

Andrew Haley aph at openjdk.org
Mon Aug 7 20:28:36 UTC 2023


On Mon, 7 Aug 2023 13:37:33 GMT, Richard Startin <duke at openjdk.org> wrote:

> We have observed invalid pointers to the interpreted method at Datadog. The fix is based on a discussion with and a code snippet from @parttimenerd.

src/hotspot/cpu/ppc/frame_ppc.cpp line 332:

> 330:   }
> 331:   Method* m = *m_addr;
> 332: 

Wouldn't it make more sense to define a function which takes a pointer to a (possible) method pointer and returns true if the method is valid?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15178#discussion_r1286354014


More information about the hotspot-dev mailing list