RFR: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer [v4]

[Richard Startin]

On Tue, 8 Aug 2023 13:45:11 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> @richardstartin I definitely think a patch in the propsed form - first check for NULL, then check again with SafeFetch - makes a lot of sense. Not perfect, but it will reduce the chance of crashes happening. And it is very simple and backportable.
>
> Hardening the API is always a good idea, especially if it doesn't have a performance impact. We generally don't know in which state ASGCT is called. I added comparable checks at many places before.

I prepared a new patch incorporating the suggestions made in this thread, which seems more straightforward to review given the force push and having gone round in circles #15193

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15178#discussion_r1287467665