RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp [v3]

[David Holmes]

On Tue, 8 Aug 2023 12:21:53 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> The JVM options that are in range of `int` type are converted in `globals.hpp` and other files where affected.
>> 
>> ### Tests
>> tiers 1-4 passed for linux-x64, linux-x64-debug, windows-x64, windows-x64-debug
>> tier1 all passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   backslash aligned

I only checked the last two flags but in both cases found related changes. Please make sure all the uses of these flags has been checked. Thanks.

src/hotspot/share/runtime/globals.hpp line 1311:

> 1309:           "Hit breakpoint when mallocing/freeing this pointer")             \
> 1310:                                                                             \
> 1311:   develop(int, StackPrintLimit, 100,                                        \

You can remove this cast now:

./share/utilities/vmError.cpp:    const int limit = max_frames == -1 ? StackPrintLimit : MIN2(max_frames, (int)StackPrintLimit);

src/hotspot/share/runtime/globals.hpp line 1748:

> 1746:           "Data sampling interval (in milliseconds)")                       \
> 1747:           range(PeriodicTask::min_interval, max_jint)                       \
> 1748:           constraint(PerfDataSamplingIntervalFunc, AfterErgo)               \

You need to change the type of the `PerfDataSamplingIntervalFunc` as well.

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15164#pullrequestreview-1568895310
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1288053102
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1288049092