RFR: 8313882: Fix -Wconversion warnings in runtime code [v2]
Coleen Phillimore
coleenp at openjdk.org
Wed Aug 9 14:15:04 UTC 2023
On Tue, 8 Aug 2023 20:10:48 GMT, Dean Long <dlong at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Make bytecode.hpp index() functions return u2 not long.
>
> src/hotspot/share/runtime/arguments.cpp line 1215:
>
>> 1213: }
>> 1214: }
>> 1215: c = getc(stream);
>
> How about int c0 for the getc value, then the first line in the loop does
> char c = checked_cast<char>(c0);
> No other changes should be needed.
There was a reason that c had to be an int. Now I'll have to rebuild and figure it out again.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15177#discussion_r1288514952
More information about the hotspot-dev
mailing list