RFR: 8313905: Checked_cast assert in CDS compare_by_loader [v2]

[Coleen Phillimore]

> Fix a checked_cast<> assert caused by changes to CDS code, but not using address calculations for comparison operators for class loaders or InstanceKlass pointers.
> Tested with tier1-4 on linux-x64-debug and windows-x64-debug.

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  Ha, didn't need the casts after all.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15208/files
  - new: https://git.openjdk.org/jdk/pull/15208/files/3e1484c3..eefcbf9d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15208&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15208&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15208.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15208/head:pull/15208

PR: https://git.openjdk.org/jdk/pull/15208