RFR: 8308850: Change JVM options with small ranges from 64 to 32 bits, for globals.hpp [v6]

David Holmes dholmes at openjdk.org
Wed Aug 9 22:35:28 UTC 2023


On Wed, 9 Aug 2023 14:54:04 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> The JVM options that are in range of `int` type are converted in `globals.hpp` and other files where affected.
>> 
>> ### Tests
>> tiers 1-4 passed for linux-x64, linux-x64-debug, windows-x64, windows-x64-debug
>> tier1 all passed.
>
> Afshin Zafari has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'master' into wconv_jvm_options
>  - Matched with master.
>  - checked all usages of changed options.
>  - backslash aligned
>  - Review comments applied.
>  - Fixed intx->int for Wconversion warnings.

Updates look good.

Thanks

src/hotspot/share/runtime/globals.hpp line 446:

> 444:           "Enable the various ring buffer event logs")                      \
> 445:                                                                             \
> 446:   product(int, LogEventsBufferEntries, 20, DIAGNOSTIC,                      \

I was going to say this should keep its unsignedness but it is treated as an `int` everywhere anyway.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15164#pullrequestreview-1570650769
PR Review Comment: https://git.openjdk.org/jdk/pull/15164#discussion_r1289260865


More information about the hotspot-dev mailing list