RFR: 8308984: Relativize last_sp (and top_frame_sp) in interpreter frames [v2]

[Fredrik Bredberg]

On Fri, 11 Aug 2023 03:15:09 GMT, Hao Sun <haosun at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Updated linux-ppc64le after review
>>  - Updated after review
>
> src/hotspot/share/runtime/frame.cpp line 1624:
> 
>> 1622:       st->print_cr(" %s  %s %s", spacer, spacer, fv.description);
>> 1623:     } else {
>> 1624:       if (on_heap
> 
> Along with the removal of this check, `on_heap` is not used in this function.
> Should we remove this parameter?

Thank you for pointing that out @shqking. Yes I think we should remove the parameter. I'll fix it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14545#discussion_r1291377072