RFR: 8313678 - SymbolTable can leak Symbols during cleanup [v4]

[Aleksey Shipilev]

On Thu, 10 Aug 2023 11:49:05 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Oli Gillespie has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Undo nullptr 'improvement'
>>    
>>    It's implemented wrong, and not sure it's worth doing anyway.
>>  - Remove .equals is_dead arg
>>    
>>    Better to use the new is_dead function.
>
> The comment seems fine.  Bit verbose but that's ok.  Don't move the refcount out of equals into the lookup function.  When we implemented this, this was where we thought this needed to be for safety, and this code has not changed to change that.

@coleenp, @dholmes-ora -- want to run it via your testing systems before we integrate, or? 

This passes tests on our side.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15137#issuecomment-1674847825