RFR: 8314114: Fix -Wconversion warnings in os code, primarily linux [v3]

[Coleen Phillimore]

On Fri, 11 Aug 2023 15:57:33 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   David's suggested changes.
>
> src/hotspot/os/posix/signals_posix.cpp line 1432:
> 
>> 1430: //    are not chained (e.g. if chaining is off), print that one too.
>> 1431: void PosixSignals::print_signal_handler(outputStream* st, int sig,
>> 1432:                                         char* buf, int buflen) {
> 
> This feels weird and wrong to me. Why change what are clearly memory sizes from size_t to a signed int? These are fed from both literals (OBUFLEN) and from sizeof(buf).

Yes, both literals are easily represented as an int, since the buffer we give to error reporting is never 30k long.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15229#discussion_r1291558943