RFR: 8314114: Fix -Wconversion warnings in os code, primarily linux [v4]

Coleen Phillimore coleenp at openjdk.org
Fri Aug 11 20:22:59 UTC 2023


On Fri, 11 Aug 2023 19:50:20 GMT, Dean Long <dlong at openjdk.org> wrote:

>> So, comment?  What should it say?
>
> I think it makes sense to have something like checked_cast here, maybe call it double_to_int(), that checks against INT_MIN and INT_MAX.  Also, using double instead of float removes the round-up problem as long as the input is <= 32 bits.

I'm going to revert this change to fix at a later time.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15229#discussion_r1291743252


More information about the hotspot-dev mailing list