RFR: 8314114: Fix -Wconversion warnings in os code, primarily linux [v2]

[Thomas Stuefe]

On Fri, 11 Aug 2023 11:58:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/os/aix/attachListener_aix.cpp line 296:
>> 
>>> 294:     // hang in the clean-up when shutting down.
>>> 295:     n = read(s, buf+off, left);
>>> 296:     assert(n <= checked_cast<ssize_t>(left), "buffer was too small, impossible!");
>> 
>> why ssize_t here?
>
> This gets a sign comparison warning without the cast, which thankfully we do enable.

I'm curious, who is warning here? Is this a static code analysis? Since I don't think Oracle builds AIX, right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15229#discussion_r1292117246