RFR: 8314114: Fix -Wconversion warnings in os code, primarily linux [v2]
Coleen Phillimore
coleenp at openjdk.org
Sat Aug 12 13:42:32 UTC 2023
On Fri, 11 Aug 2023 00:40:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/utilities/decoder_elf.cpp line 70:
>>
>>> 68: filepath[JVM_MAXPATHLEN - 1] = '\0';
>>> 69: int offset_in_library = -1;
>>> 70: if (!os::dll_address_to_library_name(pc, filepath, (int)sizeof(filepath), &offset_in_library)) {
>>
>> How about fixing dll_address_to_library_name to use size_t like all the rest of the os:: functions?
>
> It's painful. See above.
I didn't need that cast. reverting.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15229#discussion_r1292300951
More information about the hotspot-dev
mailing list