RFR: 8314114: Fix -Wconversion warnings in os code, primarily linux [v7]

Dean Long dlong at openjdk.org
Mon Aug 14 20:19:17 UTC 2023


On Mon, 14 Aug 2023 20:06:50 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use 'long' and fix -Wsign-compare warnings from previous edit.  Make max_len size_t in the three places.
>
> src/hotspot/os/linux/os_linux.cpp line 745:
> 
>> 743:   Monitor* sync = osthread->startThread_lock();
>> 744: 
>> 745:   osthread->set_thread_id(checked_cast<int>(os::current_thread_id()));
> 
> I don't see the change @dholmes-ora.
> Suggestion:
> 
>   osthread->set_thread_id(checked_cast<thread_id_t>(os::current_thread_id()));

Nevermind, I was looking at outdated changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15229#discussion_r1293926996


More information about the hotspot-dev mailing list