RFR: 8139457: Array bases are aligned at HeapWord granularity [v50]

Albert Mingkun Yang ayang at openjdk.org
Wed Aug 16 18:28:28 UTC 2023


On Wed, 16 Aug 2023 16:15:16 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

> I did that in an earlier version of this PR and it looked quite messy ...

I just checked the first commit and the `MacroAssembler` part matches what I have in mind. I believe that diff being messy is due to "Calculations of min and max array and tlab sizes".

> so we would have to check if the body is aligned or not, and if not, add an extra store

The store, as I understand it, belongs to the body (payload) semantically. Mixing stores btw `initialize_header` and `initialize_body` is super confusing, IMO.

> This is also consistent with how we store the klass-gap in instance objects there.

klass-gap is part of the header, so it makes sense to be in `initialize_header`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/11044#discussion_r1296283275


More information about the hotspot-dev mailing list