RFR: 8314265: Fix -Wconversion warnings in miscellaneous runtime code [v3]

[Thomas Stuefe]

On Wed, 16 Aug 2023 13:48:35 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Fix MaxElementPrintSize and casts. Also fixed miscellaneous -Wconversion warnings in runtime code.  This is the last one I'm going to do for runtime for a while.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert to use static_cast.

Hi Coleen,

looked at metaspace- and NMT- changes and gave the rest a cursory glance. Did not find anything to complain. Thanks for your work!

Cheers, Thomas

src/hotspot/share/logging/logOutput.cpp line 77:

> 75:     ntags++;
> 76:   }
> 77:   qsort(tags, ntags, sizeof(*tags), (_sort_Fn)tag_cmp);

While wondering about, then searching for, _sort_Fn, I found it in globalDefinitions.hpp and a wrong comment in instanceKlass.cpp

1781:    // _sort_Fn is defined in growableArray.hpp.

would you mind fixing that comment or removing it?

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15233#pullrequestreview-1581233101
PR Review Comment: https://git.openjdk.org/jdk/pull/15233#discussion_r1296307276