RFR: 8313302: Fix formatting errors on Windows [v5]
Julian Waters
jwaters at openjdk.org
Thu Aug 17 05:55:30 UTC 2023
On Wed, 16 Aug 2023 07:54:12 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Julian Waters has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Remove whitespace
>> - Revert changes of INTPTR_FORMAT, minor improvements
>
> src/hotspot/os/windows/gc/z/zMapper_windows.cpp line 267:
>
>> 265:
>> 266: if (!res) {
>> 267: fatal_error("Failed to split placeholder", static_cast<uintptr_t>(addr), size);
>
> Suggestion:
>
> fatal_error("Failed to split placeholder", untype(addr), size);
won't these trigger assertions inside fatal error reporting code as Thomas mentioned earlier?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15063#discussion_r1296707683
More information about the hotspot-dev
mailing list