RFR: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint [v2]

Vladimir Kempik vkempik at openjdk.org
Thu Aug 17 08:17:29 UTC 2023


On Thu, 17 Aug 2023 06:30:47 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Ilya Gavrilin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change fsgnj_d(dst, src, src) to fmv_d(dst, src)
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 1236:
> 
>> 1234:     rmode_floor,
>> 1235:     rmode_rint
>> 1236:   };
> 
> Why not use the existing `RoundDoubleModeNode::rmode_ceil`, `RoundDoubleModeNode::rmode_floor` and `RoundDoubleModeNode::rmode_rint` instead?

not sure it's good idea: RoundDoubleModeNode enum is purely C2 entity. Using some C2 enum in macroAssembler_riscv ( not c2_MacroAssembler_riscv) doesn't sound good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14991#discussion_r1296845599


More information about the hotspot-dev mailing list